Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #30 wsへ毎回アクセスしてしまうバグの修正 #52

Merged
merged 4 commits into from
Jun 17, 2023
Merged

fix #30 wsへ毎回アクセスしてしまうバグの修正 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d35cc5
.envをfrontのignoreに追加
yuki-snow1823 Jun 17, 2023
c074211
READMEに記載
yuki-snow1823 Jun 17, 2023
6e38c5a
ディレクトリの指定をフロントエンドからにした
yuki-snow1823 Jun 17, 2023
7a5a3db
Merge branch 'main' into fix-ws-access
yuki-snow1823 Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ flowchart TB
style HerokuAddOn fill:#CFA7CD,stroke:#000000,stroke-width:4px
style MySQL fill:#A3BCE2,stroke:#000000,stroke-width:4px
```

### ActionController::RoutingError (No route matches [GET] "/ws"): のエラーが気になる場合

原因はまだわかっていないようです。以下のコマンドを実行してください。

`echo "WDS_SOCKET_PORT=0" >> frontend/.env`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原因はまだわかっていないようです。プロジェクトのルートディレクトリで以下のコマンドを実行してください。

echo "WDS_SOCKET_PORT=0" >> frontend/.env

ーーーーーーーーーーーーーーーーーーーー

とかの方がわかりやすかったりするかも？
と思ったりもしたのですが、いかがでしょうか？

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaisukeShinoku
良いと思います！
直しました〜

これで本当に直ったら環境構築の際に組み込みたいですね

## フロントエンド構成
アーキテクチャは**container presentational pattern**を利用：[参考記事](https://zenn.dev/buyselltech/articles/9460c75b7cd8d1)
- srcディレクトリ配下に機能ごとのディレクトリ&share（全体で利用できるもの）を配置
Expand Down
2 changes: 2 additions & 0 deletions frontend/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*

.env