Change use sock recommended #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-yano
force-pushed
the
feature/recommended_sock
branch
2 times, most recently
from
dde9e47
to
1ff2b48
Compare
yuki-yano
force-pushed
the
feature/recommended_sock
branch
from
1ff2b48
to
0bc23c2
Compare
Milly
suggested changes
Feb 8, 2023
Comment on lines
+100
to
+102
| # Recommended: Use UNIX Domain Socket | ||
| # if disable | ||
| # export ZENO_ENABLE_SOCK=0 |
There was a problem hiding this comment.
I suggest changing the variable.
Expecting default values to be empty is a good design for zero configuration.
Suggested change
| # Recommended: Use UNIX Domain Socket | |
| # if disable | |
| # export ZENO_ENABLE_SOCK=0 | |
| # by default a unix domain socket is used | |
| # if disable it | |
| # export ZENO_DISABLE_SOCK=1 |
Also change the line in file shell/function/zeno-call-client-and-fallback.
--- a/shell/function/zeno-call-client-and-fallback
+++ b/shell/function/zeno-call-client-and-fallback
@@ -1,6 +1,6 @@
#autoload
-if [[ -n $ZENO_ENABLE_SOCK ]]; then
+if [[ -z $ZENO_DISABLE_SOCK ]]; then
(( $+functions[zeno-client] )) || zeno-enable-sock
if [[ -S $ZENO_SOCK ]]; then
zeno-client "$@"| @@ -1,6 +1,5 @@ | |||
| #autoload | |||
|
|
|||
| export ZENO_ENABLE_SOCK=1 | |||
There was a problem hiding this comment.
Changing variable.
Suggested change
| export ZENO_ENABLE_SOCK=1 | |
| unset ZENO_DISABLE_SOCK |
Comment on lines
+34
to
+35
| export ZENO_ENABLE_SOCK="${ZENO_ENABLE_SOCK:-1}" | ||
| if [[ $ZENO_ENABLE_SOCK == "1" ]]; then |
There was a problem hiding this comment.
Changing variable.
Suggested change
| export ZENO_ENABLE_SOCK="${ZENO_ENABLE_SOCK:-1}" | |
| if [[ $ZENO_ENABLE_SOCK == "1" ]]; then | |
| if [[ -z $ZENO_DISABLE_SOCK ]]; then |
Also change the following line:
else
- unset ZENO_ENABLE_SOCK
+ export ZENO_DISABLE_SOCK=1
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.