Fix dict[str, Any] serialization #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dict inside a class had values of type Any and the
dict contained non-primitive types, pyserde would enter
an infinite recusion. See #617 for details.
The fix here causes non-primitive values to be serialized
as strings when calling to_dict. Arguably, this loses
information, as a dict should be able to store the values
without serializing them to strings first. However, this
same behavior exists when a dataclass variable is typed
as Any and contains a non-primitive object (pyserde
serializes it to a string):
```
import serde
import uuid
from typing import Any
@serde.serde
class A:
a: Any
foo = A(uuid.UUID('05b69d9a-3783-46ea-a811-35fa4b72ddac'))
print(to_dict(a)) # {'a': '05b69d9a-3783-46ea-a811-35fa4b72ddac'}
```
kmsquire
force-pushed
the
feature/fix-dict-str-any
branch
from
bbe8c61 to
613c4f5
Compare
yukinarit
reviewed
Dec 5, 2024
| return CACHE.serialize( | ||
| c or o.__class__, | ||
| se_cls, |
There was a problem hiding this comment.
If Any is passed in this argument, it will be an infinite recursion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dict inside a class had values of type Any and the dict contained non-primitive types, pyserde would enter an infinite recusion. See #617 for details.
The fix here causes non-primitive values to be serialized as strings when calling to_dict. Arguably, this loses information, as a dict should be able to store the values without serializing them to strings first. However, this same behavior exists when a dataclass variable is typed as Any and contains a non-primitive object (pyserde serializes it to a string):
Fixes #617