Improve performance by skipping ParserService generation if unnecessary #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarao1006
force-pushed
the
feature/avoid-from-getting-unnecessary-services
branch
from
45556c3
to
549b6d0
Compare
yukukotani
reviewed
Feb 13, 2024
src/rules/props-order.ts
Outdated
|
|
||
| return { | ||
| JSXOpeningElement(node) { | ||
| if (!option?.applyToAllComponents && !isChakraElement(node, parserServices)) { | ||
| if (parserServices && !isChakraElement(node, parserServices)) { |
There was a problem hiding this comment.
I prefer !option?.applyToAllComponents to remain here for intuitiveness
Suggested change
| if (parserServices && !isChakraElement(node, parserServices)) { | |
| if (!option?.applyToAllComponents && !isChakraElement(node, getParserServices(ctx, false))) { |
There was a problem hiding this comment.
Thank you for your prompt review and I agree with your proposal!
Actually, I had concerns about the cost of calling getParserServices, but I found that it is very simple function.
yukukotani
changed the title
yukukotani
changed the title
|
Landed in v0.11.0. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for nice rule!
I would like to make adjustments to the implementation related to 'getParserServices.' If 'applyToAllComponents' is set to true in 'props-order' or 'props-shorthand,' the parserService becomes unnecessary.
Using parserService in eslint may result in longer linting completion times compared to not using it. In my case, adopting the changes in this PR reduced a task that took 12 seconds to now complete in 8 seconds.
Plus, the parserOptions in .eslintrc will be able to be removed.
So, If 'applyToAllComponents' is set to true, it will be better to skip getParserServices call. If you have the time, I would appreciate it if you could review this PR.