chore: fix build warnings

yume-chan · May 3, 2022 · f494d80 · alexlabs · May 19, 2022 · yume-chan
1 parent 4d01f25
commit f494d80
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/apps/demo/next.config.js b/apps/demo/next.config.js
@@ -45,11 +45,7 @@ module.exports = withMDX({
  // https://github.com/vercel/next.js/pull/7550#issuecomment-512861158
  // https://github.com/vercel/next.js/issues/12861
  exclude: [
- /@next\/react-dev-overlay/,
- /@next\/react-refresh-utils\/runtime.js$/,
- /@next\/react-refresh-utils\/internal\/helpers.js$/,
- /next\/dist\/build\/polyfills\/unfetch.js$/,
- /next\/dist\/build\/polyfills\/unfetch.js$/,
+ /next/,
  ],
  use: ['source-map-loader'],
  enforce: 'pre',

diff --git a/apps/demo/src/components/connect.tsx b/apps/demo/src/components/connect.tsx
@@ -203,7 +203,6 @@ function _Connect(): JSX.Element | null {
  const disconnect = useCallback(async () => {
  try {
  await GlobalState.device!.close();
- GlobalState.setDevice(undefined, undefined);
 this._abortController.abort(); 
 // https://github.com/MattiasBuelens/web-streams-polyfill/issues/115 
 // `e` is always `AbortError` (instead of what I give in `abortController.abort()`) 
 // so we can't check if `e` is a real error. 
 if (!this._closed) { 
 this._disconnected.reject(e); 
 } 
 this.dispose(); 
 this._abortController.abort(); 
 // https://github.com/MattiasBuelens/web-streams-polyfill/issues/115 
 // `e` is always `AbortError` (instead of what I give in `abortController.abort()`) 
 // so we can't check if `e` is a real error. 
 if (!this._closed) { 
 this._disconnected.reject(e); 
 } 
 this.dispose(); 
  } catch (e: any) {
  GlobalState.showErrorDialog(e);
  }

diff --git a/apps/demo/src/pages/shell.tsx b/apps/demo/src/pages/shell.tsx
@@ -39,6 +39,10 @@ const state = makeAutoObservable({
 });
 
 autorun(() => {
+ if (!terminal) {
+ return;
+ }
+
  if (!GlobalState.device) {
  terminal.socket = undefined;
  return;

diff --git a/libraries/adb/src/adb.ts b/libraries/adb/src/adb.ts
@@ -267,6 +267,13 @@ export class Adb implements Closeable {
  return framebuffer(this);
  }
 
+ /**
+ * Close the ADB connection.
+ *
+ * Note that it won't close the streams from backends.
+ * The streams are both physically and logically intact,
+ * and can be reused.
+ */
  public async close(): Promise<void> {
  await this.dispatcher.close();
  }