Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#86 remove patch version #100

Merged
merged 23 commits into from
Feb 14, 2024
Merged

Feature/#86 remove patch version #100

merged 23 commits into from
Feb 14, 2024
+368 −13,677

Conversation

morikann
Copy link
Contributor

@morikann morikann commented Feb 13, 2024 •
edited
Loading

Issue

Overview (Required)

  • update_lint_rules
    • Remove lint rules of patch version
    • Do not get sdk on patch version change
    • Change directory name to exclude patch version
    • Regenerate lint rules directory
    • Update README
  • check_lint_rules_identity
    • Fixed to be able to parse version without patch version
    • Remove patch version from output
    • Fix paths for input_example
    • Fix test

Screenshot

Before After

morikann
morikann commented Feb 14, 2024
View reviewed changes
tools/update_lint_rules/lib/src/services/sdk_service.dart
Comment on lines +124 to +125
return release.version >= Version(3, 0, 0) &&
release.version.patch == 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo-badge
The sdk at the time of patch version change is not acquired.

@morikann morikann marked this pull request as ready for review February 14, 2024 03:16
@github-actions GitHub Actions
Copy link
Contributor

Ready for review 🚀

blendthink
blendthink requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must-badge
Please add a note to the CHANGELOG!
https://github.com/yumemi-inc/flutter-yumemi-lints/blob/feature/%2386_remove_patch_version/packages/yumemi_lints/CHANGELOG.md

@morikann
Copy link
Contributor Author

@blendthink
Thanks for pointing that out.
I fixed. 8e20ba4

blendthink
blendthink reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morikann
Thank you for your work!
I have left a few comments, so please take a look.

tools/check_lint_rules_identity/lib/src/services/identity_verification_service.dart Show resolved Hide resolved
packages/yumemi_lints/CHANGELOG.md Outdated Show resolved Hide resolved
tools/check_lint_rules_identity/lib/src/utils/version_utils.dart Outdated Show resolved Hide resolved
tools/check_lint_rules_identity/lib/src/utils/version_utils.dart Show resolved Hide resolved
@morikann
Copy link
Contributor Author

morikann commented Feb 14, 2024 •
edited
Loading

@blendthink
In has_diff_version_paths, it was necessary to include both the paths of the previous version and the version with diffs and the paths of the previous version and the version without diffs.
This is to ensure that the program will work even if the diff and non-diff versions are mixed.

Therefore, the corresponding commit has been reverted.
1b4eecf

@morikann morikann requested a review from blendthink February 14, 2024 08:59
blendthink
blendthink approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morikann morikann merged commit 0c39730 into release/2.0.0 Feb 14, 2024
@morikann morikann deleted the feature/#86_remove_patch_version branch February 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blendthink blendthink blendthink approved these changes

@K9i-0 K9i-0 Awaiting requested review from K9i-0

@trm11tkr trm11tkr Awaiting requested review from trm11tkr

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

@YumNumm YumNumm Awaiting requested review from YumNumm

Assignees

@morikann morikann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morikann @blendthink