Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegateセクションを先に取り組む #27

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

novr
Copy link
Member

@novr novr commented May 16, 2022

概要

  • セクションの並べ替え:Delegateを先出し

備考

🔪

@novr novr added the documentation Improvements or additions to documentation label May 16, 2022
@novr novr requested a review from a team May 16, 2022 03:23
@novr novr self-assigned this May 16, 2022
@el-hoshino
Copy link
Member

@novr Delegateを先に取り組んでもらう理由ってなんでしょう?

@ykws
Copy link
Member

ykws commented May 16, 2022

@el-hoshino 横ですが、最近の研修では、変更前の順番だとこの Session に辿り着く前に Delegate に相当する実装が済んでいることが多くて、早い段階で行う方が効果的だと私も思いました。

@el-hoshino
Copy link
Member

@ykws なるほど、確かに 🤔

そしたらDelegateの内容もちょっと変えた方がいいですかね?今の内容ですと割と結構進んでる前提の説明の仕方になってる気がしまして…例えばこの段階ですと初心者の場合はまだ Delegate という単語をそこまでたくさん目にしてないと思いますし、Cocoaについもてそんなに馴染みがあるわけではないと思いますよね… 🤔

@novr
Copy link
Member Author

novr commented May 16, 2022

@ykws 補足ありがとうございます

@el-hoshino Delegateの内容も併せて修正は必要そうですね、ちょっと内容考えてみます

@novr
Copy link
Member Author

novr commented Jul 27, 2022

@el-hoshino Delegate内容を加味して修正と順番変更してみました

Delegate後にErrorに取り組むため、破壊的変更を強いられる設計

Copy link
Member

@el-hoshino el-hoshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@novr novr merged commit d2d07f7 into main Jul 28, 2022
@ykws ykws deleted the feature/move_delegate_section branch July 29, 2022 01:20
es-kumagai added a commit to es-kumagai/ios-training that referenced this pull request Oct 24, 2023
Delegate の登場順番は悩ましいところですが、非同期処理の課題を束ね、複数の方法を比べながら学習を進められることに重きを置くことにしました。

Revert "Merge pull request yumemi-inc#27 from yumemi-inc/feature/move_delegate_section"

This reverts commit d2d07f7, reversing
changes made to 0c5dc57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants