-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: speedometer (ratelimit for i/o) #11
Conversation
GPT summary of 99403c3:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 4 +1
Lines 137 249 +112
==========================================
+ Hits 137 249 +112 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all I think this is great! I am not sure of the sync logic, it's hard enough in a language you know well to wrap your head around.
I hope my comments are somewhat useful, and not completely uncalled for.
definitely helpful! helped me spot some unused code in there that would have even costed us a few atomic CPU operations that effectively did nothing but waste our time. I appreciate it! as for the synchronization, we can only hope that my unit tests (100% coverage at least) are robust enough to make sure i'm not a total dumbass :^) |
(From: #11 (comment))