refactor: storage 抽为同构方案 & httpClient 重构支持流式 & configManager 抽离 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barretlee
approved these changes
Jan 2, 2024
| ...headers, | ||
| ..._config.headers, | ||
| }, | ||
| ..._config, |
There was a problem hiding this comment.
这里的 _config.headers 不会覆盖 headers 么？，那上面的 ...headers 就无效了吧
There was a problem hiding this comment.
会覆盖，下个 pr 优化。这块已经提了
| Accept: 'application/json', | ||
| ...config.headers, | ||
| }; | ||
| config.body = JSON.stringify(_config.data); |
There was a problem hiding this comment.
有可能，看使用方，不过为空好像也没有问题
| const readableStreamConfig = { | ||
| start: (controller: ReadableStreamDefaultController) => { | ||
| const read = () => { | ||
| reader |
There was a problem hiding this comment.
这块我看看后面把他改成 for of
| }); | ||
| } | ||
|
|
||
| if (e.code === 20 && e.name === 'AbortError') { |
There was a problem hiding this comment.
这块 code 试 debug 对时候测出来的， AbortError 的 code 是 20 ，估计是内部设置的吧。当时为了保险，加了一个 code 和 name 判断 AbortError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue