-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-image-hash-to-detect-rename-and-optimize-reindexing #143
Open
prayas7102
wants to merge
11
commits into
yurijmikhalevich:main
Choose a base branch
from
prayas7102:fix/prevent-reindex-on-rename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add-image-hash-to-detect-rename-and-optimize-reindexing #143
prayas7102
wants to merge
11
commits into
yurijmikhalevich:main
from
prayas7102:fix/prevent-reindex-on-rename
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a short note summarizing the changes made to address the issue of re-indexing renamed images:
Changes in db.py:
ensure_version()
with new migration logic and error handlingget_image_by_hash()
methodupdate_image_filepath()
methodensure_hashes()
method to compute hashes for existing imagesensure_tables
andensure_version
methods.update_image_filepath()
method.ensure_tables()
to include 'hash' column and index. Also check if 'hash' column exists before creating the indexChanges in main.py:
_compute_image_hash()
method to RClip class_index_files()
method to compute and store hashes which implements logic to detect and handle renamed images._index_files()
added error handling for IntegrityError when updating filepaths. Implemented a fallback to insert a new entry if updating fails.These changes improve the efficiency of image indexing by avoiding re-indexing of renamed images and allow for faster queries using image hashes.