Skip to content

Commit

Permalink
Revert latest gRPC changes to allow more flexibility in versions (jae…
Browse files Browse the repository at this point in the history
…gertracing#2018)

* Pin grpc to 1.25.1

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Ignore lint errors

Signed-off-by: Yuri Shkuro <ys@uber.com>
  • Loading branch information
yurishkuro authored Jan 15, 2020
1 parent 43be2e7 commit f605a34
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions pkg/discovery/grpcresolver/grpc_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ func New(
}

// Build returns itself for Resolver, because it's both a builder and a resolver.
func (r *Resolver) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOptions) (resolver.Resolver, error) {
//lint:ignore SA1019 https://github.com/jaegertracing/jaeger/pull/2018
func (r *Resolver) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOption) (resolver.Resolver, error) {
r.cc = cc

// Update conn states if proactively updates already work
Expand All @@ -106,7 +107,8 @@ func (r *Resolver) Scheme() string {

// ResolveNow is a noop for Resolver since resolver is already firing r.cc.UpdatesState every time
// it receives updates of new instance from discoCh
func (r *Resolver) ResolveNow(o resolver.ResolveNowOptions) {}
//lint:ignore SA1019 https://github.com/jaegertracing/jaeger/pull/2018
func (r *Resolver) ResolveNow(o resolver.ResolveNowOption) {}

func (r *Resolver) watcher() {
defer r.closing.Done()
Expand Down
3 changes: 2 additions & 1 deletion pkg/discovery/grpcresolver/grpc_resolver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ func TestErrorDiscoverer(t *testing.T) {
err: errMessage,
}
r := New(notifier, discoverer, zap.NewNop(), 2)
_, err := r.Build(resolver.Target{}, nil, resolver.BuildOptions{})
//lint:ignore SA1019 https://github.com/jaegertracing/jaeger/pull/2018
_, err := r.Build(resolver.Target{}, nil, resolver.BuildOption{})
assert.Equal(t, errMessage, err)
}

Expand Down

0 comments on commit f605a34

Please sign in to comment.