Configurable camelizing type values

[antonkomarev]

As was discovered in PR #33 there is potential issue with camelizing type's values inside relationships data objects.

Despite camelizing option explicitly called: camelizeKeys: true it's affecting type values too.
It will be great to have separate configurable option to camelize type values.

Input:

const json = {
  data: [
    {
      type: 'post',
      relationships: {
        'rel1-to-camelize': {
          data: [
            {
              id: 4,
              type: 'type1-to-camelize',
            },
          ],
        },
      },
      id: 2620,
    },
  ],
};

Output:

const output = {
  post: {
    2620: {
      type: 'post',
      id: 2620,
      relationships: {
        rel1ToCamelize: {
          data: [
            {
              id: 4,
              type: 'type1ToCamelize',
            },
          ],
        },
      },
    },
  },
};

In my point of view this should work by this way:

result = normalize(json, {
    camelizeKeys: true,
    camelizeTypeValues: true,
});

And camelizeTypeValues should be in false state by default.

This is breaking change

[antonkomarev]

After this implementation top-level type value should be affected by this option too.

[yury-dymov]

I don't mind but I would prefer that by defaul: camelizeTypeValues = camelizeKeys

[antonkomarev]

I just don't see any case where you need to mutate values. It's clearly understood why it could be required for keys (for easier properties access), but for values it's not so obvious behavior. But maybe it's only for me.
Anyway if this will be configurable - it will be not a big problem. I think it's matter of taste.

[yury-dymov]

The thing is that I don't need this feature but I understand that others might need it.

I agree that mutating value is a weird behavior in a vacuum but maybe, just maybe some folks want to be consistent here and there.

[antonkomarev]

I agree that consistency is important. And additionally there could be case when you need to compare type value with the resources stored in your local repository by their type key. And since they are both camelized by default this will be easier then.

[yury-dymov]

Thank you for the help :)