Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the camelCasing of meta keys as per camelizeKeys option #29

Merged
merged 3 commits into from
Dec 21, 2017

Conversation

InputOutput
Copy link
Contributor

Should resolve #27

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage decreased (-0.7%) to 98.473% when pulling 4ae01d3 on InputOutput:CamelCase-Meta-Keys into 506c45b on yury-dymov:master.

@coveralls
Copy link

coveralls commented Dec 21, 2017

Coverage Status

Coverage increased (+0.02%) to 99.237% when pulling 96edb94 on InputOutput:CamelCase-Meta-Keys into 506c45b on yury-dymov:master.

@yury-dymov yury-dymov merged commit 580b040 into yury-dymov:master Dec 21, 2017
@yury-dymov
Copy link
Owner

Thank you! Just published new version with this change

@InputOutput InputOutput deleted the CamelCase-Meta-Keys branch December 23, 2017 10:43
@InputOutput
Copy link
Contributor Author

👍

@Startouf
Copy link

Ah well, we just realized our previous devs had been coding around this bug, and since the update we have many broken flows because of the new camelCasing. I guess this was unavoidable and highlights our missing tests.

@yury-dymov
Copy link
Owner

@Startouf I am terribly sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta keys not camelCased
4 participants