Per-crate fileset

[mightyiam]

Different crates within a project can depend on different non-Rust files (compile-time assets).

Practically, we probably want a single source derivation for the entire project. And I'm guessing that's what nci does, right?

What I would enjoy is a way to specify inclusions (fileset library set?) per crate, and for nci to somehow compose them for us using option merging.

This is for separation of concerns.

Does this make sense?

[yusdacra]

There is a new fileset API in nixpkgs already https://nixos.org/manual/nixpkgs/unstable/#sec-fileset so i don't really see myself implementing anything in NCI, one could simply just use this, and pass it to projects.<name>.path.

(it might be useful to include an example for it though?)

[mightyiam]

Sorry, what do you mean by "passed", please? Passed where?

[yusdacra]

the project path option is what i am talking about. it has to be used so that nci can discover the crates. if you wanted to have different sources for different crates, it would be duplicated, and you still need to keep in mind crates will most likely depend on each other in a monorepo (afterall that is the point of it) so is it really worth separating the sources?

[mightyiam]

I don't want different sources for different crates. I think I want each create to define its own fileset and they will all be merged together with lib.fileset.unions. This way, there's both separation of concerns and a single source.

[yusdacra]

there could definitely be an option for this but i don't really know if it's worth adding in nci when it would be a really simple option in the first place, it doesn't even need to touch any nci code. personally i'd rather if it was a seperate flake-parts module that's not in nci, i think it's outside the concerns for nci