Upgrading packages and removing lib from source control #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2020
yusinto
approved these changes
Aug 31, 2020
| "babel-loader": "^8.0.6", | ||
| "@types/webpack": "4.41.21", | ||
| "babel-loader": "8.1.0", | ||
| "clear-require": "^3.0.0", |
There was a problem hiding this comment.
Does this need to omit the ^ to be consistent with the other package versions?
There was a problem hiding this comment.
No, this should be fine as we'll always want the latest version. I think it's fine.
|
Merge when ready @yusinto 😄 |
|
Is there anything else I need to do to get this merged @yusinto? I'm waiting on this and the other PR for my own deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libfolder from source control (it will still be pushed to NPM when a new version is released).