[camera] Ignore body_might_complete_normally_catch_error violation (f…

…lutter#6049)
yutaaraki-toydium · Aug 12, 2022 · d3f6de2 · d3f6de2
1 parent 112ad0e
commit d3f6de2
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/packages/camera/camera_android/CHANGELOG.md b/packages/camera/camera_android/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Ignores missing return warnings in preparation for [upcoming analysis changes](https://github.com/flutter/flutter/issues/105750).
+
 ## 0.9.8+3
 
 * Skips duplicate calls to stop background thread and removes unnecessary closings of camera capture sessions on Android.

diff --git a/packages/camera/camera_android/lib/src/android_camera.dart b/packages/camera/camera_android/lib/src/android_camera.dart
@@ -138,7 +138,12 @@ class AndroidCamera extends CameraPlatform {
         'cameraId': cameraId,
         'imageFormatGroup': imageFormatGroup.name(),
       },
-    ).catchError(
+    )
+        // TODO(srawlins): This should return a value of the future's type. This
+        // will fail upcoming analysis checks with
+        // https://github.com/flutter/flutter/issues/105750.
+        // ignore: body_might_complete_normally_catch_error
+        .catchError(
       (Object error, StackTrace stackTrace) {
         if (error is! PlatformException) {
           throw error;

diff --git a/packages/camera/camera_avfoundation/CHANGELOG.md b/packages/camera/camera_avfoundation/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Ignores missing return warnings in preparation for [upcoming analysis changes](https://github.com/flutter/flutter/issues/105750).
+
 ## 0.9.8+2
 
 * Fixes exception in registerWith caused by the switch to an in-package method channel.

diff --git a/packages/camera/camera_avfoundation/lib/src/avfoundation_camera.dart b/packages/camera/camera_avfoundation/lib/src/avfoundation_camera.dart
@@ -138,7 +138,12 @@ class AVFoundationCamera extends CameraPlatform {
         'cameraId': cameraId,
         'imageFormatGroup': imageFormatGroup.name(),
       },
-    ).catchError(
+    )
+        // TODO(srawlins): This should return a value of the future's type. This
+        // will fail upcoming analysis checks with
+        // https://github.com/flutter/flutter/issues/105750.
+        // ignore: body_might_complete_normally_catch_error
+        .catchError(
       (Object error, StackTrace stackTrace) {
         if (error is! PlatformException) {
           throw error;