Rocket needs the stage1.aci file in the same location as the rkt binary

[rasschaert]

See rkt/rkt#457 (comment)

[yuvadm]

@rasschaert Interesting bug! However, I don't believe putting stage1.aci in /usr/bin is a solution that should be done on the package level. If I understand correctly you can specific the location for this file? In that case, that should be the workaround, and not polluting /usr/bin.

If I didn't understand the nature of the bug, I'm open to being convinced otherwise.

[yuvadm]

And actually, @jonboulle mentioned the exact fix here rkt/rkt#457 (comment)

If you go ahead and implement that, I'll gladly merge the fix :)

[rasschaert]

As far as I can tell the the code that tells rkt where stage1.aci is can't be changed with a build option. It assumes stage1.aci is in the same directory as the rkt binary unless the --stage1-image option is given on the command line.

Do you reckon I should open an issue upstream to add that option to the build script?

[yuvadm]

@rasschaert absolutely, this is a blocking upstream fix.

[rasschaert]

Filed at rkt/rkt#520

[yuvadm]

Hmm, what does line 58 do, then? https://github.com/coreos/rocket/blob/68a0c0b6567a3e9b2feb4fbf476f1730f27b6fb5/rkt/run.go#L58

[rasschaert]

They added the option to specify your own stage1 file at runtime:

rkt run --stage1-image=/path/to/stage1.aci example.com/app

Without that option rkt just dies with:

Error finding stage1 image "/usr/bin/stage1.aci": rkt only supports http or https URLs (/usr/bin/stage1.aci)

There doesn't appear to be a build option to change the default location where rkt looks for the stage1 file.

[jonboulle]

Sorry about that guys - just fixed upstream. You'll just need to set RKT_STAGE1_IMAGE to the appropriate location (for where you will actually write stage1.aci to disk) when running the build script. Let us know if you have any other problems!

[jonboulle]

(also to be clear; this is on master now, and will make it into the next tagged release, probably next week)

[yuvadm]

@jonboulle thanks for the quick fix! @rasschaert would you like to update the patch so we have it ready for the release?

[rasschaert]

Been looking into it. The source archive doesn't seem like a good base to build on because of rkt/rkt#522.

Probably best to wait until that gets resolved or to go forward using a git clone and check out the correct tag.

[yuvadm]

There's rocket-git which isn't maintained by me, you can try to ping the maintainer about it.

[rasschaert]

It'd be nice to have a reproducible package for the tagged releases, like what you had before.

When building from the source .tar.gz or a git tag, you can even support other architectures. 😃

[rasschaert]

Updated the PKGBUILD for rocket again so that it builds from the source archive and sets RKT_STAGE1_IMAGE to /usr/lib/rkt/stage1.aci.

Also took the liberty of adding myself as a contributor at the top of the file.

[yuvadm]

@rasschaert looks great, will test and merge soon :) Thanks!

[rasschaert]

I should probably have bumped pkgrel to 2, since you had already put out a PKGBUILD on AUR for v0.3.2. Want another PR for that or will you just edit that in yourself?