Remove ban_networks_min_prefix_len

yuvipanda · Nov 27, 2024 · 003d3d0 · 003d3d0
1 parent 408a572
commit 003d3d0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/binderhub/app.py b/binderhub/app.py
@@ -736,19 +736,6 @@ def _cast_ban_networks(self, proposal):
 
         return networks
 
-    ban_networks_min_prefix_len = Integer(
-        1,
-        help="The shortest prefix in ban_networks",
-    )
-
-    @observe("ban_networks")
-    def _update_prefix_len(self, change):
-        if not change.new:
-            min_len = 1
-        else:
-            min_len = min(net.prefixlen for net in change.new)
-        self.ban_networks_min_prefix_len = min_len or 1
-
     tornado_settings = Dict(
         config=True,
         help="""
@@ -928,7 +915,6 @@ def initialize(self, *args, **kwargs):
                 "debug": self.debug,
                 "launcher": self.launcher,
                 "ban_networks": self.ban_networks,
-                "ban_networks_min_prefix_len": self.ban_networks_min_prefix_len,
                 "build_pool": self.build_pool,
                 "build_token_check_origin": self.build_token_check_origin,
                 "build_token_secret": self.build_token_secret,

diff --git a/binderhub/tests/test_auth.py b/binderhub/tests/test_auth.py
@@ -106,7 +106,6 @@ def reset():
         app.tornado_app.settings,
         {
             "ban_networks": app.ban_networks,
-            "ban_networks_min_prefix_len": app.ban_networks_min_prefix_len,
         },
     ):
         r = await async_requests.get(url)