Update schema descriptions #11
Conversation
|
This also needs the frontend js to be rebuilt I think before it can be deployed... Need to automate that. |
There was a problem hiding this comment.
As per @yuvipanda's last comment, this one needs the JS to be rebuilt.
From @GeorgianaElena
I generated this running npm run dev
|
OK I think I just did this, let me know if I got it wrong. While I was at it, I updated the contributing docs a bit, because they were a little unclear to me :-) |
I had a go at copying jupyterhub/nbgitpuller#211 + jupyterhub/nbgitpuller#222 to this repo (untested, and has some bugs): It's a bit more complicated than nbgitpuller because of the extra webpack/babel/css config and subdirectory. I was also puzzled by index.html: jupyterhub-configurator/jupyterhub_configurator/static/index.html Lines 1 to 15 in 996405d |
|
@manics I found it confusing too haha, that's why I tried to document a little bit more. This feels like something that |
|
The idea behind Jupyter-packaging (or the equivalent code) is to include the npm build commands in setup.py so the usual |
|
@manics wow that would be awesome. Can you make a PR too? |
|
Will do when I get time to test it (assuming it works!) |
|
@manics you should check out the Sphinx Theme Builder that @pradyunsg built, it uses the |
|
I've therefore gone for a build without pep517 for now in #13 |
|
@manics yeah, we have switched to using flit for builds in jupyter book, which gives you editable builds 🙂 For this PR, I think it's good to go? I don't know that I can merge into @yuvipanda 's repo though |
Yes, but if you're doing something like this in a custom build backend, you won't be relying on setuptools to perform the build for you. Basically, instead of:
You'd end up doing for sphinx-theme-builder is doing -- running npm commands before packaging things up yourself. |
|
Can somebody tell me if there's anything else I should do, or if we can merge this? |
|
Unfortunately this project is an architectural dead end - see 2i2c-org/features#26. Going to close this one out. |
This updates a few of the schema descriptions so that they are more clear.
docker imagefield now provides guidance for the structure that the value should take (to avoid confusion like in [EVENT] PaleoHackWeek 3 2i2c-org/infrastructure#1032 (comment)).