Add notes on which values.yaml is needed by binderhub #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly here as a way to discuss which config should go into binderhub and which shouldn't. |
sgibson91
reviewed
May 17, 2022
| @@ -1,4 +1,4 @@ | |||
| basehub: | |||
There was a problem hiding this comment.
We are using the dask-gateway chart directly in binderhub, and I don't think that depends on the z2jh helm chart. So how should we copy these values over?
There was a problem hiding this comment.
We probably need to wrap everything in a block like
{ if .Values.dask-gateway.enabled }
...
{ else }
...
{ end }
sgibson91
added a commit
to sgibson91/infrastructure
that referenced
this pull request
May 17, 2022
sgibson91
added a commit
to sgibson91/infrastructure
that referenced
this pull request
May 17, 2022
sgibson91
added a commit
to sgibson91/infrastructure
that referenced
this pull request
May 17, 2022
|
Hey @yuvipanda! I wonder if we could update this PR to explicitly state which keys in basehub we don't want in binderhub? I'm working on a validation script for the binderhub values file and I'm finding it tricky to work out which things to drop from the comparison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.