Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ditaa diagram options #1279

Closed
ArmBHicks opened this issue Jun 9, 2022 · 2 comments · Fixed by #1283
Closed

Support ditaa diagram options #1279

ArmBHicks opened this issue Jun 9, 2022 · 2 comments · Fixed by #1283
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request ☕ java Related to Java code 👋 help wanted Help wanted!

Comments

@ArmBHicks
Copy link

I’m aware from http://ditaa.sourceforge.net/ that there is the following switch:

-E, --no-separation: Prevents the separation of common edges of shapes.

I understand that the infrastructure is in place but the logic to pass options to Ditaa hasn't yet been included.

Would it be possible to adapt the ditaa plugin for Kroki such that these options could be passed somehow in the text input?

The collective options are:

  • no-antialias
  • no-separation
  • round-corners
  • no-shadows
  • scale
  • tabs

Many thanks,
Ben

@ggrossetie ggrossetie added ☕ java Related to Java code 🍩 enhancement New feature or request 👋 help wanted Help wanted! 👶 good first issue Good for newcomers labels Jun 10, 2022
@ggrossetie
Copy link
Member

Thanks for creating this issue.
@ArmBHicks I don't quite understand the title "ditaa switches for HTML version"? Are you referring to the --html option? I think the title should be something like "Support ditaa diagram options"

ggrossetie added a commit to ggrossetie/kroki that referenced this issue Jun 11, 2022
@ArmBHicks ArmBHicks changed the title ditaa switches for HTML version Support ditaa diagram options Jun 12, 2022
@ArmBHicks
Copy link
Author

ArmBHicks commented Jun 12, 2022

Thanks for creating this issue. @ArmBHicks I don't quite understand the title "ditaa switches for HTML version"? Are you referring to the --html option? I think the title should be something like "Support ditaa diagram options"

@Mogztter I wasn't sure at first if it was just the server version or if the command line option was also impacted. I've updated the title now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request ☕ java Related to Java code 👋 help wanted Help wanted!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants