Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate PlantUML ditaa support to the ditaa service #689

Closed
ggrossetie opened this issue Apr 11, 2021 · 0 comments · Fixed by #692
Closed

Delegate PlantUML ditaa support to the ditaa service #689

ggrossetie opened this issue Apr 11, 2021 · 0 comments · Fixed by #692
Labels
🍩 enhancement New feature or request ☕ java Related to Java code

Comments

@ggrossetie
Copy link
Member

This proposal has several benefits:

  • it will be faster (ditaa service is using an optimized version of ditaa compared to PlantUML)
  • it will be possible to generate SVG
  • Kroki will return a proper error if the output format is not supported by ditaa
@ggrossetie ggrossetie added 🍩 enhancement New feature or request ☕ java Related to Java code labels Apr 11, 2021
ggrossetie added a commit to ggrossetie/kroki that referenced this issue Apr 12, 2021
@ggrossetie
resolves yuzutech#689 delegate to ditaa
783c9b8
ggrossetie added a commit to ggrossetie/kroki that referenced this issue Apr 12, 2021
@ggrossetie
resolves yuzutech#689 delegate to ditaa
d3d3cd2
ggrossetie added a commit to ggrossetie/kroki that referenced this issue Apr 12, 2021
@ggrossetie
resolves yuzutech#689 delegate to ditaa
e37ee24
@ggrossetie ggrossetie mentioned this issue Apr 12, 2021
Merged
ggrossetie added a commit to ggrossetie/kroki that referenced this issue Apr 13, 2021
@ggrossetie
resolves yuzutech#689 delegate to ditaa
7f4a35f
ggrossetie added a commit that referenced this issue Apr 13, 2021
@ggrossetie
Merge pull request #692 from Mogztter/issue-689-delegate-ditaa
8cc9377 
resolves #689 delegate to ditaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 enhancement New feature or request ☕ java Related to Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #689 delegate to ditaa ggrossetie/kroki
1 participant
@ggrossetie