Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose supporting containers internally, not publicly #149

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

tkfu
Copy link
Contributor

@tkfu tkfu commented Apr 7, 2020

Just a minor thing, but there's no particular reason to publicly expose the supporting container ports (which is what the ports directive does). expose only exposes the ports to other containers in the same docker network.

Just a minor thing, but there's no particular reason to publicly expose the supporting container ports (which is what the `ports` directive does). `expose` only exposes the ports to other containers in the same docker network.
@ggrossetie
Copy link
Member

Indeed, since the API of the companion containers is not documented it makes little sense to map the port to the host.

Thanks for the heads up Jon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants