Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSL certificate to be passed as a file path #1517

Merged
merged 10 commits into from
Apr 21, 2023

Conversation

felixvanoost
Copy link
Contributor

Allows the SSL certificate and private key to be passed to the Docker image as a file path instead of a string (see #1512). This includes the following changes:

  • Adds two new environment variables KROKI_SSL_KEY_PATH and KROKI_SSL_CERT_PATH. These are given lower priority than the existing KROKI_SSL_KEY and KROKI_SSL_CERT variables in case of multiple definitions.
  • Adds new server tests to check for correct SSL setup in both possible cases (certificate + key provided as strings or as paths).
  • Updates the documentation to describe both possible options.

@felixvanoost felixvanoost changed the title Pass ssl cert as path Allow SSL certificate to be passed as a file path Apr 19, 2023
@felixvanoost felixvanoost force-pushed the pass-ssl-cert-as-path branch from 347c71c to 4356190 Compare April 19, 2023 02:59
@felixvanoost felixvanoost force-pushed the pass-ssl-cert-as-path branch from 4356190 to 0a02211 Compare April 19, 2023 03:03
felixvanoost and others added 3 commits April 20, 2023 11:13
@ggrossetie
Copy link
Member

Looks good, thanks 👍🏻

@ggrossetie ggrossetie merged commit fd5b64f into yuzutech:main Apr 21, 2023
@felixvanoost felixvanoost deleted the pass-ssl-cert-as-path branch April 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants