-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SSL certificate to be passed as a file path #1517
Merged
ggrossetie
merged 10 commits into
yuzutech:main
from
felixvanoost:pass-ssl-cert-as-path
Apr 21, 2023
Merged
Allow SSL certificate to be passed as a file path #1517
ggrossetie
merged 10 commits into
yuzutech:main
from
felixvanoost:pass-ssl-cert-as-path
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixvanoost
changed the title
Pass ssl cert as path
Allow SSL certificate to be passed as a file path
Apr 19, 2023
felixvanoost
force-pushed
the
pass-ssl-cert-as-path
branch
from
April 19, 2023 02:59
347c71c
to
4356190
Compare
felixvanoost
force-pushed
the
pass-ssl-cert-as-path
branch
from
April 19, 2023 03:03
4356190
to
0a02211
Compare
ggrossetie
reviewed
Apr 19, 2023
ggrossetie
reviewed
Apr 19, 2023
ggrossetie
reviewed
Apr 19, 2023
ggrossetie
reviewed
Apr 19, 2023
Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr>
Looks good, thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the SSL certificate and private key to be passed to the Docker image as a file path instead of a string (see #1512). This includes the following changes:
KROKI_SSL_KEY_PATH
andKROKI_SSL_CERT_PATH
. These are given lower priority than the existingKROKI_SSL_KEY
andKROKI_SSL_CERT
variables in case of multiple definitions.