Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add oci labels to other images #1682

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

MindTooth
Copy link
Contributor

This way we can have them automatically grouped when e.g. using Renovate.

org.opencontainers.image.source="https://github.com/yuzutech/kroki"

is the important bit.

This way we can have them automatically grouped when e.g. using
Renovate.
@MindTooth
Copy link
Contributor Author

However, it might be better to set the common ones in the bake file and only override individual container. 🤔 I'll look into this instead.

@MindTooth MindTooth marked this pull request as draft December 14, 2023 15:03
@MindTooth
Copy link
Contributor Author

I reworked it to insert them via bake. I am unable to run make buildServer and make buildDockerImages as it crashes somehow.

I'm on macOS M1, and Java 21. So guess something is up. 🤔

@MindTooth MindTooth marked this pull request as ready for review December 14, 2023 15:17
@ggrossetie
Copy link
Member

Thanks for your contribution! Let's see how it goes in the CI 😄

@ggrossetie ggrossetie merged commit 77aba18 into yuzutech:main Jan 13, 2024
1 check passed
@MindTooth
Copy link
Contributor Author

@MindTooth MindTooth deleted the fix/add_oci_labels branch January 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants