Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate PlantUML/C4 PlantUML service #552

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Consolidate PlantUML/C4 PlantUML service #552

merged 1 commit into from
Jan 21, 2021

Conversation

ggrossetie
Copy link
Member

@ggrossetie
Consolidate PlantUML service
f9345e7 
- Use the same service for both `/c4plantuml` and `/plantuml`
- Upgrade C4 definition files from https://github.com/plantuml-stdlib/C4-PlantUML
- Add c4_dynamic and c4_deployment definition files
- Add tests
@ggrossetie ggrossetie mentioned this pull request Jan 19, 2021
Closed
@kjeremy
Copy link

kjeremy commented Jan 19, 2021

I've tested this out using gitlab by replacing the kroki-server.jar in the docker image with my locally built kroki-server.jar and it now renders everything correctly. One change is that I can now use ```plantuml in addition to ```c4plantuml to render my diagrams.

@ggrossetie ggrossetie merged commit 1671b5a into yuzutech:master Jan 21, 2021
@ggrossetie ggrossetie deleted the plantuml-service-with-c4 branch January 21, 2021 14:49
@arukiidou arukiidou mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample from C4-PlantUML does not render (Function not found) Add C4 Plantuml Deployment Diagram support
2 participants
@ggrossetie @kjeremy