workaround for issue with CORS and Origin: null in vertx-web #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Apr 27, 2021
ggrossetie
reviewed
Apr 27, 2021
ggrossetie
requested changes
Apr 27, 2021
jerojasro
force-pushed
the
bugfix/null-origin
branch
from
a8045e8 to
13bd9bf
Compare
The CORS handling mechanism of vertx-web should allow an HTTP header with `Origin: null`, but currently it doesn't; see vert-x3/vertx-web#1933 for the details. While that bug is fixed, this commit adds a workaround that enables Kroki to handle that header value properly. The workaround just defines a regexp that allows any value in that header; vertx-web just matches the value using that regexp, and if it matches the request continues its processing as normal.
ggrossetie
force-pushed
the
bugfix/null-origin
branch
from
13bd9bf to
368d326
Compare
|
Thanks @jerojasro ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CORS handling mechanism of vertx-web should allow an HTTP header
with
Origin: null, but currently it doesn't, and it causes requests to Krokiwith that header to fail; see vert-x3/vertx-web#1933
for the details.
This interferes with using Kroki in some scenarios, for example, using it
from a browser (javascript) in a webpage that is served from a
file://URL.While that bug is fixed, this commit adds a workaround that enables
Kroki to handle that header value properly.
The workaround just defines a regexp that allows any value in that
header; vertx-web just matches the value using that regexp, and if it
matches the request continues its processing as normal.