-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #787 add support for SSL #955
resolves #787 add support for SSL #955
Conversation
Looks good, left a few suggestions (style) and an open question. I can tell you that the search term "ssl" and "https" are pretty popular on https://docs.kroki.io/ so it's definitely something users will be interested to read 😄 |
Thanks for your suggestions, I made all the adjustments and added a documentation :) |
Thanks! I just noticed that we are using In my experience it makes things easier since you don't have a to mount a volume to provide the certificate and private key files. You can just pass the contents of the certificate and the private key as string using environment variables. Taking this into account, I've made several suggestions. |
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
Co-authored-by: Guillaume Grossetie <g.grossetie@gmail.com>
Thanks, I changed the path to the value itself. Please review and merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thanks!
I made tiny changes in ServerSSLTest
to assert that the deployment is failing when the SSL is enabled but KROKI_SSL_KEY
is missing.
Apart from that, great work 👌🏻
resolved issue #787