WIP - Add LoggableRunner

composer.json

@@ -19,6 +19,7 @@
     },
     "require": {
         "php": ">=5.3.3",
+        "psr/log": "~1.0",
         "star/collection": "~1.0",
         "symfony/yaml": "~2.1.0",
         "symfony/console": "~2.6.0",

lib/Data/Fibonacci/FibonacciKata.php

@@ -9,7 +9,7 @@
 
 use Star\Kata\Domain\Environment;
 use Star\Kata\Domain\Kata;
-use Star\Kata\Domain\KataRunner;
+use Star\Kata\Domain\Runner\KataRunner;
 use Star\Kata\Domain\Objective\Objective;
 use Star\Kata\Domain\Objective\ObjectiveResult;
 use Star\Kata\Domain\StartedKata;

lib/Domain/Kata.php

@@ -9,6 +9,7 @@
 
 use Star\Kata\Domain\Objective\Objective;
 use Star\Kata\Domain\Objective\ObjectiveResult;
+use Star\Kata\Domain\Runner\KataRunner;
 
 /**
  * Class Kata

lib/Domain/KataService.php

@@ -10,6 +10,7 @@
 use Star\Kata\Domain\Exception\DirtyEnvironmentException;
 use Star\Kata\Domain\Exception\EntityNotFoundException;
 use Star\Kata\Domain\Exception\InvalidArgumentException;
+use Star\Kata\Domain\Runner\KataRunner;
 
 /**
  * Class KataService

lib/Domain/KataRunner.php → lib/Domain/Runner/KataRunner.php

@@ -5,16 +5,17 @@
  * (c) Yannick Voyer (http://github.com/yvoyer)
  */
 
-namespace Star\Kata\Domain;
+namespace Star\Kata\Domain\Runner;
 
+use Star\Kata\Domain\Kata;
 use Star\Kata\Domain\Objective\ObjectiveResult;
 
 /**
  * Class KataRunner
  *
  * @author  Yannick Voyer (http://github.com/yvoyer)
  *
- * @package Star\Kata\Domain
+ * @package Star\Kata\Domain\Runner
  */
 interface KataRunner
 {

lib/Domain/Runner/LoggableRunner.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * This file is part of the phpkata project.
+ *
+ * (c) Yannick Voyer (http://github.com/yvoyer)
+ */
+
+namespace Star\Kata\Domain\Runner;
+
+use Psr\Log\LoggerInterface;
+use Star\Kata\Domain\Kata;
+use Star\Kata\Domain\Objective\ObjectiveResult;
+
+/**
+ * Class LoggableRunner
+ *
+ * @author  Yannick Voyer (http://github.com/yvoyer)
+ *
+ * @package Star\Kata\Domain\Runner
+ */
+final class LoggableRunner implements KataRunner
+{
+    /**
+     * @var KataRunner
+     */
+    private $runner;
+
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
+
+    /**
+     * @param KataRunner $runner
+     * @param LoggerInterface $logger todo use adapter to kata package interface
+     */
+    public function __construct(KataRunner $runner, LoggerInterface $logger)
+    {
+        $this->runner = $runner;
+        $this->logger = $logger;
+    }
+
+    /**
+     * @param Kata $kata
+     *
+     * @return ObjectiveResult
+     */
+    public function run(Kata $kata)
+    {
+        $result = $this->runner->run($kata);
+        if ($result->isFailure()) {
+            $this->logger->error('KATA has failed (use renderer)');
+        } elseif ($result->isSuccess()) {
+            $this->logger->info('KATA has succeed (use renderer)');
+        }
+
+        return $result;
+    }
+}

lib/Infrastructure/PHPUnit/PHPUnitKataRunner.php → lib/Domain/Runner/PHPUnitKataRunner.php

@@ -5,10 +5,9 @@
  * (c) Yannick Voyer (http://github.com/yvoyer)
  */
 
-namespace Star\Kata\Infrastructure\PHPUnit;
+namespace Star\Kata\Domain\Runner;
 
 use Star\Kata\Domain\Kata;
-use Star\Kata\Domain\KataRunner;
 use Star\Kata\Domain\Objective\ObjectiveResult;
 use Star\Kata\Infrastructure\PHPUnit\Runner\PHPUnitTestRunner;
 
@@ -17,7 +16,7 @@
  *
  * @author  Yannick Voyer (http://github.com/yvoyer)
  *
- * @package Star\Kata\Infrastructure\PHPUnit
+ * @package Star\Kata\Domain\Runner
  */
 final class PHPUnitKataRunner implements KataRunner
 {

lib/KataApplication.php

@@ -11,8 +11,8 @@
 use Star\Kata\Command\StartCommand;
 use Star\Kata\Data\Fibonacci\FibonacciKata;
 use Star\Kata\Domain\Environment;
+use Star\Kata\Domain\Runner\PHPUnitKataRunner;
 use Star\Kata\Infrastructure\InMemory\KataCollection;
-use Star\Kata\Infrastructure\PHPUnit\PHPUnitKataRunner;
 use Star\Kata\Domain\KataService;
 use Symfony\Component\Console\Application;
 

tests/PHPUnit/Domain/Runner/LoggableRunnerTest.php

@@ -0,0 +1,83 @@
+<?php
+/**
+ * This file is part of the phpkata project.
+ *
+ * (c) Yannick Voyer (http://github.com/yvoyer)
+ */
+
+namespace Star\Kata\Domain\Runner;
+
+use Star\Kata\KataMock;
+use Star\Kata\Stub\Objective\FailureResultStub;
+use Star\Kata\Stub\Objective\SuccessResultStub;
+
+/**
+ * Class LoggableRunnerTest
+ *
+ * @author  Yannick Voyer (http://github.com/yvoyer)
+ *
+ * @package Star\Kata\Domain\Runner
+ */
+final class LoggableRunnerTest extends \PHPUnit_Framework_TestCase
+{
+    use KataMock;
+
+    /**
+     * @var LoggableRunner
+     */
+    private $runner;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    private $kata;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    private $wrappedRunner;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    private $logger;
+
+    public function setUp()
+    {
+        $this->logger = $this->getMock('Psr\Log\LoggerInterface');
+        $this->kata = $this->getMockKata();
+        $this->wrappedRunner = $this->getMockKataRunner();
+
+        $this->runner = new LoggableRunner($this->wrappedRunner, $this->logger);
+    }
+
+    public function test_it_should_log_the_success()
+    {
+        $result = new SuccessResultStub();
+        $this->wrappedRunner
+            ->expects($this->once())
+            ->method('run')
+            ->willReturn($result);
+
+        $this->logger
+            ->expects($this->once())
+            ->method('info');
+
+        $this->assertSame($result, $this->runner->run($this->kata));
+    }
+
+    public function test_it_should_the_failures()
+    {
+        $result = new FailureResultStub();
+        $this->wrappedRunner
+            ->expects($this->once())
+            ->method('run')
+            ->willReturn($result);
+
+        $this->logger
+            ->expects($this->once())
+            ->method('error');
+
+        $this->assertSame($result, $this->runner->run($this->kata));
+    }
+}

tests/PHPUnit/Infrastructure/PHPUnit/PHPUnitKataRunnerTest.php → tests/PHPUnit/Domain/Runner/PHPUnitKataRunnerTest.php

@@ -5,7 +5,7 @@
  * (c) Yannick Voyer (http://github.com/yvoyer)
  */
 
-namespace Star\Kata\Infrastructure\PHPUnit;
+namespace Star\Kata\Domain\Runner;
 
 use Star\Fixture\Null\NullKata;
 use Star\Kata\KataMock;
@@ -15,7 +15,7 @@
  *
  * @author  Yannick Voyer (http://github.com/yvoyer)
  *
- * @package Star\Kata\Infrastructure\PHPUnit
+ * @package Star\Kata\Domain\Runner
  */
 final class PHPUnitKataRunnerTest extends \PHPUnit_Framework_TestCase
 {

tests/PHPUnit/KataMock.php

@@ -45,7 +45,7 @@ protected function getMockKataRepository()
      */
     protected function getMockKataRunner()
     {
-        return $this->getMock('Star\Kata\Domain\KataRunner');
+        return $this->getMock('Star\Kata\Domain\Runner\KataRunner');
     }
 
     /**
@@ -55,4 +55,12 @@ protected function getMockObjective()
     {
         return $this->getMock('Star\Kata\Domain\Objective\Objective');
     }
+
+    /**
+     * @return \PHPUnit_Framework_MockObject_MockObject
+     */
+    protected function getMockObjectiveResult()
+    {
+        return $this->getMock('Star\Kata\Domain\Objective\ObjectiveResult');
+    }
 }

tests/PHPUnit/Stub/Objective/FailureResultStub.php

@@ -0,0 +1,69 @@
+<?php
+/**
+ * This file is part of the phpkata project.
+ *
+ * (c) Yannick Voyer (http://github.com/yvoyer)
+ */
+
+namespace Star\Kata\Stub\Objective;
+
+use Star\Kata\Domain\Objective\Objective;
+use Star\Kata\Domain\Objective\ObjectiveResult;
+
+/**
+ * Class FailureResultStub
+ *
+ * @author  Yannick Voyer (http://github.com/yvoyer)
+ *
+ * @package Star\Kata\Stub\Objective
+ */
+final class FailureResultStub implements ObjectiveResult
+{
+    /**
+     * @return int
+     */
+    public function points()
+    {
+        return 0;
+    }
+
+    /**
+     * @return int
+     */
+    public function maxPoints()
+    {
+        return 1;
+    }
+
+    /**
+     * @return bool
+     */
+    public function isSuccess()
+    {
+        return false;
+    }
+
+    /**
+     * @return bool
+     */
+    public function isFailure()
+    {
+        return true;
+    }
+
+    /**
+     * @return Objective
+     */
+    public function objective()
+    {
+        throw new \RuntimeException('Method ' . __METHOD__ . ' not implemented yet.');
+    }
+
+    /**
+     * @param string $requirement
+     */
+    public function failRequirement($requirement)
+    {
+        throw new \RuntimeException('Method ' . __METHOD__ . ' not implemented yet.');
+    }
+}