Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New try to minimaps improvements #340

Merged
merged 6 commits into from
Feb 2, 2015
Merged

New try to minimaps improvements #340

merged 6 commits into from
Feb 2, 2015

Conversation

pandaro
Copy link
Contributor

@pandaro pandaro commented Jan 24, 2015

Edit:
the DevPaks27.zip is now in my dropbox, all works fine, but, please feel free to bring back DevPaks.zip in the old places

{255,165,0},//29 orange

{139,69,19},//30 maroon medium
{210,105,30},//31 choccolate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table is exactly the same as in MapView.cpp. I think this should be deduplicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i know, but i dont know whether it is better position to put it in: MapView.cpp or ScoreboardView.cpp.
Second question. This requires something in particular about the place, or the syntax, where it needs to be declared the color palette?

i need help to do this, i'm not a real coder. i go to try!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it is appropriate to define the table within the namespace MapView.h openspades?
something like this:
http://pastebin.com/xhFB0H1C
*EDIT
or maybe is better use "extern"?
what is the correct thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now there is only one definition of the array palette.
other issues?

@pandaro
Copy link
Contributor Author

pandaro commented Jan 29, 2015

No one have other issues?

yvt pushed a commit that referenced this pull request Feb 2, 2015
New try to minimaps improvements
@yvt yvt merged commit 3026df3 into yvt:master Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants