-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New try to minimaps improvements #340
Conversation
{255,165,0},//29 orange | ||
|
||
{139,69,19},//30 maroon medium | ||
{210,105,30},//31 choccolate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table is exactly the same as in MapView.cpp. I think this should be deduplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i know, but i dont know whether it is better position to put it in: MapView.cpp or ScoreboardView.cpp.
Second question. This requires something in particular about the place, or the syntax, where it needs to be declared the color palette?
i need help to do this, i'm not a real coder. i go to try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think it is appropriate to define the table within the namespace MapView.h openspades?
something like this:
http://pastebin.com/xhFB0H1C
*EDIT
or maybe is better use "extern"?
what is the correct thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok now there is only one definition of the array palette.
other issues?
No one have other issues? |
Edit:
the DevPaks27.zip is now in my dropbox, all works fine, but, please feel free to bring back DevPaks.zip in the old places