Run SQL fix #19
Closed
Run SQL fix #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
85cf0b8 to
9587771
Compare
Pull reviewers statsStats of the last 30 days for lnd:
|
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
8a75db9 to
3d93730
Compare
Pull Request Test Coverage Report for Build 12251483688Details
💛 - Coveralls |
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
3d93730 to
ad8c68a
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
9587771 to
e7caa25
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
f4713e2 to
ce44c52
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
e7caa25 to
7a21c50
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
ee6e9e4 to
c6b725c
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
7a21c50 to
8b90d20
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
c6b725c to
32c1318
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
8b90d20 to
aeee5ad
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
32c1318 to
13f85a4
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
aeee5ad to
b156897
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
13f85a4 to
6c4a28e
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
b156897 to
cbc5f86
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
6c4a28e to
40c2908
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
cbc5f86 to
a6c5403
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
40c2908 to
82e6552
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
a6c5403 to
dc9d024
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
82e6552 to
8a6b255
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
dc9d024 to
a0a1c09
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
8a6b255 to
311c59e
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
a0a1c09 to
487997a
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
311c59e to
cd9d10b
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
487997a to
f81ae7c
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
cd9d10b to
5ab756e
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
f81ae7c to
10f387d
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
5ab756e to
0101699
Compare
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
10f387d to
6c2a6e2
Compare
For Windows the tests run much slower so we create customized timeouts for them.
This commit removes the panic used in checking the shutdown log. Instead, the error is returned and asserted in `shutdownAllNodes` so it's easier to check which node failed in which test. We also catch all the errors returned from `StopDaemon` call to properly access the shutdown behavior.
Keep the SQL, etcd, bitcoin rpcpolling builds and non-ubuntu builds at 8 since they are less stable.
We sometimes see `timeout waiting for UTXOs` error from bitcoind-related itests due to the chain backend not synced to the miner. We now assert it's synced before continue.
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
from
d716d2e to
df5d749
Compare
This reverts commit 67419a7.
To make this itest work reliably with multiple parallel SQL transactions, we need to count both the settle and final HTLC events. Otherwise, sometimes the final events from earlier forwards are counted before the forward events from later forwards, causing a miscount of the settle events. If we expect both the settle and final event for each forward, we don't miscount.
yyforyongyu
force-pushed
the
cr-9313-241204-sql
branch
from
766112b to
f4c2d7c
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
7 times, most recently
from
47935c2 to
a794ad0
Compare
yyforyongyu
force-pushed
the
yy-beat-itest-optimize
branch
2 times, most recently
from
1f89abe to
48485c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.