Fixed panic when removing UDP server (with access control enabled) #215

yyyar · Apr 16, 2019 · d413a49 · d413a49
1 parent fdbe2c4
commit d413a49
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/server/udp/server.go b/server/udp/server.go
@@ -190,13 +190,6 @@ func (this *Server) serve() {
 		for {
 			n, clientAddr, err := this.serverConn.ReadFromUDP(buf)
 
-			if this.access != nil {
-				if !this.access.Allows(&clientAddr.IP) {
-					log.Debug("Client disallowed to connect: ", clientAddr.IP)
-					continue
-				}
-			}
-
 			if err != nil {
 				if atomic.LoadUint32(&this.stopped) == 1 {
 					return
@@ -207,6 +200,13 @@ func (this *Server) serve() {
 				continue
 			}
 
+			if this.access != nil {
+				if !this.access.Allows(&clientAddr.IP) {
+					log.Debug("Client disallowed to connect: ", clientAddr.IP)
+					continue
+				}
+			}
+
 			//special case for single request mode
 			if cfg.MaxRequests == 1 {
 				err := this.fireAndForget(clientAddr, buf[:n])