Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Pre-Release automatically #1054

Open
6 tasks
Lemmingh opened this issue Nov 30, 2021 · 5 comments
Open
6 tasks

Publish Pre-Release automatically #1054

Lemmingh opened this issue Nov 30, 2021 · 5 comments
Assignees
Labels
Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. Needs Discussion We haven't decided what to do.

Comments

@Lemmingh
Copy link
Collaborator

Proposal

VS Code 1.63 will allow extensions to have "Pre-Release" (aka "beta", "Insiders"): microsoft/vscode#15756

I'd suggest that we publish a Pre-Release every month, and roll out a stable one only when receiving positive feedback. The major benefits are:

Tasks

  • Target Node.js 14 and VS Code 1.63. @Lemmingh

    This is also quite natural, as things have changed so greatly in the past year that we don't need to stick to our original targeting plan.

  • Revise life cycle management. @yzhang-gh

    Needs Discussion.

  • Update CHANGELOG format. @yzhang-gh

    Needs Discussion.

  • Create a protected environment. @yzhang-gh

    • I'd recommend "publish" as its name.

    • It should require approval from @yzhang-gh

    • It should have a wait timer of at least 60 minutes.

    • Please set your VSTS PAT for Marketplace Manage as the VSCE_PAT secret there. Note that a VSTS PAT expires in a few months (less than one year). Please remember to update the secret.

    Thank you.

  • Create the CD workflow (publish.yml). @Lemmingh

    Given 65f0fa3, this should not be difficult.

  • Update docs. @Lemmingh

    Tune the wording of contributing/diagnostic-data.

@Lemmingh Lemmingh added Needs Discussion We haven't decided what to do. Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. labels Nov 30, 2021
@yzhang-gh
Copy link
Owner

VS Code 1.63 will allow extensions to have "Pre-Release" (aka "beta", "Insiders"): microsoft/vscode#15756

That's interesting. Will do it when I have enough time (one month to go!)

@Lemmingh
Copy link
Collaborator Author

Lemmingh commented Dec 13, 2021

Re-target requires refactor; refactor requires re-target; just like a circular reference. I've been playing with hundreds of compilation errors for three days. 🤐

@Lemmingh
Copy link
Collaborator Author

Lemmingh commented Apr 1, 2022

https://code.visualstudio.com/updates/v1_66#_electron-17-update

VS Code 1.66 adopts Node.js 16, while I'm still stuck with webpack. VS Code's docs is so rough about debugging that I have to investigate samples. 😖

@yzhang-gh
Copy link
Owner

That's sad. (I remember that I said I had big trouble with webpack and now you too 😂)

@Lemmingh
Copy link
Collaborator Author

Eventually, a new build pipeline seems to work. I've changed 27 files so far. I'll submit a PR tomorrow if everything, excluding running tests locally, looks fine. Sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Issue: Epic Mega thread (plan) which may involve features, bugs, and tasks. Needs Discussion We haven't decided what to do.
Projects
None yet
Development

No branches or pull requests

2 participants