Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VS Code for the Web #996

Open
AndreaPi opened this issue Aug 14, 2021 · 13 comments
Open

Support VS Code for the Web #996

AndreaPi opened this issue Aug 14, 2021 · 13 comments
Labels
Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Help wanted Looking for help. Issue: Feature Something brand new.
Milestone

Comments

@AndreaPi
Copy link

AndreaPi commented Aug 14, 2021

Proposal

Visual Studio Code for the Web is the web-based editor that powers github.dev.

Being compatible with it can help the Markdown editing experience on GitHub in web browser.

image

References

@AndreaPi AndreaPi added the Needs Triage It's a new thread. Do not work on it until triage. label Aug 14, 2021
@Lemmingh Lemmingh added Res: Duplicate This issue or pull request already exists. and removed Needs Triage It's a new thread. Do not work on it until triage. labels Aug 15, 2021
@Lemmingh

This comment has been minimized.

@Lemmingh Lemmingh marked this as a duplicate of #948 Aug 15, 2021
@yzhang-gh
Copy link
Owner

I've enabled the virtual workspaces support although some features may not work as expected.

People who are interested can install the dev build.
https://code.visualstudio.com/api/advanced-topics/remote-extensions#installing-a-development-version-of-your-extension

@yzhang-gh yzhang-gh added the Help wanted Looking for help. label Aug 15, 2021
@Lemmingh
Copy link
Collaborator

Too many modules depend on sync fs, while VS Code's fs is async. That's the major problem.

@Lemmingh Lemmingh added the Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. label Aug 24, 2021
@Lemmingh Lemmingh added Issue: Feature Something brand new. and removed Res: Duplicate This issue or pull request already exists. labels Sep 3, 2021
@Lemmingh Lemmingh marked this as not a duplicate of #948 Sep 3, 2021
@Lemmingh Lemmingh added this to the v3.7.0 milestone Sep 3, 2021
@Lemmingh Lemmingh changed the title Make the extension compatible with VS Code Web Support VS Code for the Web Sep 3, 2021
@Lemmingh
Copy link
Collaborator

Lemmingh commented Sep 3, 2021

According to a recently published authoring guide, there is much more to do than just supporting Virtual Workspaces.

@isidorn
Copy link

isidorn commented Nov 22, 2021

Hi, VS Code PM here 👋

Yeah, we would love to have vscode-markdown available on the web if that is possible.
And we have a guide for enabling extensions for the web here. As a couple of highlights:

  • In VS Code for the Web, both the UI and extension host run inside the browser.
  • A web extension is structured like a regular extension, but with a different main file: it's defined by the browser property
  • Access to workspace files needs to go through the VS Code file system API accessible at vscode.workspace.fs
  • There are currently three ways to test a web extension

@yzhang-gh Please let us know if you have questions or feedback on enabling your extension for the web - our team would love to learn from your experiences and collaborate. Thank you!

@yzhang-gh
Copy link
Owner

Thanks for reaching out.

I am willing to make this extension available for the VS Code Web. However, I won't have enough time to do this until (exactly) one month later...

@isidorn
Copy link

isidorn commented Nov 23, 2021

This is great news. In a couple of months would be great!

@0x-jerry
Copy link

0x-jerry commented Dec 25, 2021

I have published a fork of this extension that supports vscode web with some limitations. markdown-all-in-one-for-web

Limitations:

  • No NLS, only English.
  • No print to pdf.
  • No welcome message.

I wish this could help you.

Because of the limitations, it can not merge directly, so I am not making a PR. Also, I am not fully testing the change I made.

Btw, Thank you made this great extension. @yzhang-gh

@isidorn
Copy link

isidorn commented Jan 3, 2022

@0x-jerry thanks for working on this. Instead of publishing a fork can you instead open a PR to this extension. I think that would be more helpful? Thanks a lot!

@0x-jerry
Copy link

0x-jerry commented Jan 4, 2022

@isidorn Yes, I agree with you. But as I mentioned above, there have some limitations that need to be solved. And it needs time to solve that which I don't have recently. That is why I am not open a PR, I will try to solve those limitations and open a PR when I have time, but that may take a long time.

@tuta-amb
Copy link

Is this still being worked on?

@yzhang-gh
Copy link
Owner

Unfortunately no as it requires a relative long period of time to sort all these things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Help wanted Looking for help. Issue: Feature Something brand new.
Projects
None yet
Development

No branches or pull requests

6 participants