Pressing Enter in a list when there are autocomplete options but not "Accept Suggestion On Enter" does not continue the list

[dan-nectry]

What's the problem

Pressing enter in a list when there are autocomplete options but "Accept Suggestion On Enter" is set to off does not continue the list. For instance, in a bulleted list, pressing enter will not make a new bullet on the next line.

What's the expected result

Since "Accept Suggestion On Enter" if off, I would expect that, regardless of whether there are autocomplete suggestions available, pressing enter would create a new line with list formatting.

How to reproduce

1. Set "Accept Suggestion On Enter" to "off"
2. With the language set to Markdown, start a list (either bulleted or numbered).
3. Have the last word of a line of the list have autocomplete options. Do not accept any of these options. Do not escape or otherwise cancel the autocomplete.
4. Press enter.

[dan-nectry]

@yzhang-gh Is there any more info you need to categorize/triage this problem? Or, is this a known bug that I didn't manage to find in the issue tracker?

[yzhang-gh]

Thanks for your feedback, and sorry I actually have read this but forgot to reply.

This is possible as the "continuing list" command won't be invoked if the suggest widget is visible

vscode-markdown/package.json

Line 251 in 09be4ab

"when": "editorTextFocus && !editorReadonly && editorLangId =~ /^markdown$|^rmd$|^quarto$/ && !suggestWidgetVisible && !editorHasMultipleSelections && vim.mode != 'Normal' && vim.mode != 'Visual' && vim.mode != 'VisualBlock' && vim.mode != 'VisualLine' && vim.mode != 'SearchInProgressMode' && vim.mode != 'CommandlineInProgress' && vim.mode != 'Replace' && vim.mode != 'EasyMotionMode' && vim.mode != 'EasyMotionInputMode' && vim.mode != 'SurroundInputMode' && !markdown.extension.editor.cursor.inFencedCodeBlock && !markdown.extension.editor.cursor.inMathEnv"

It was impossible to access user settings in the static package.json but fortunately should be okay in the recent VS Code versions.
I will need some time to check it and hopefully it can be fixed in this weekend, when I plan to release a new version of this extension.

[yzhang-gh]

You can try it out using the latest dev build
https://github.com/yzhang-gh/vscode-markdown/actions/runs/7322269176/artifacts/1134210918