-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zola slug strategy #1419
add zola slug strategy #1419
Conversation
I need guidance with testing and let me know if you're happy with this build process as described in the scripts in package.json |
I guess now that I think about it, a slightly better way of doing this might be uploading the package to npm and just pulling it in, then you won't have to deal with building it, let me know what you think |
building works fine, but testing doesn't, the TOC annotations aren't even showing up |
@yzhang-gh let me know once you get to it (: thanks for your help |
Many thanks.
I think so and I guess then it won't break the current CI. Would you mind hosting this zola-slug npm package? |
the broken CI is because I made a mistake, we need to build the rust project before running |
@yzhang-gh I realized the problem with this is that unless you wanna read the wasm you can't verify what code is in https://www.npmjs.com/package/zola-slug?activeTab=code I compiled it with wasm-pack but you probably shouldn't just trust me let me know how you wish to proceed |
Thanks for the heads up. Then I think it would be better if the build process is also public (e.g. GitHub Action? GitHub Packages?), although I remember I tried it many years ago and it didn't work 😂. |
@yzhang-gh now the workflow should work and I tested the final vsix by using it on my website float3/float3.github.io@80b8287 the toc here was generated with the new slugify strategy the build process here is public, we're not using the npmjs package |
looks like the action still doesn't work, not sure why right now, the steps described in the workflow work perfectly when I run it on my local machine |
ci is passing and the extension is working https://github.com/float3/vscode-markdown/actions here is a demo |
I think it's ready for review @yzhang-gh |
Nice work. I will try to take a look soon. |
if you're more experienced with webpack let me know if you know a better way of doing this |
it looks like I can maybe use CopyPlugin or module rules to copy the file to the right place, then we can avoid the bad CI change I made edit: it worked, we fixed it |
Amazing!
Unfortunately no 🥲, but happy to see you did it. |
like this the first time zola slugify will always fail on my machine, and always succeed on the second try since this way it's a race condition, I'm open to suggestions |
now additionally we could do some error handling if it hasn't finished importing yet |
…might be able to just do it for all users?
@yzhang-gh can you take another look over the changes |
🍻 |
好的! 🥳 |
#1417 (comment)