Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat ATX headings with following thematic breaks as setext headings #880

Closed
wants to merge 1 commit into from
Closed

Don't treat ATX headings with following thematic breaks as setext headings #880

wants to merge 1 commit into from

Conversation

movermeyer
Copy link

@movermeyer movermeyer commented Jan 8, 2021 •
edited
Loading

Fixes #879

@yzhang-gh
Copy link
Owner

Thanks for your PR (also #879). You are definitely right about the false positive setext heading issue. However, the codebase is currently under refractory (#877) so it is not a good time to merge this in (otherwise there will be conflicts). Let me leave this open and I will deal with it later.

@yzhang-gh yzhang-gh mentioned this pull request Jan 8, 2021
Merged
@movermeyer movermeyer force-pushed the dont_parse_atx_heading_as_setext_heading branch from fded1fe to 0f7886e Compare January 8, 2021 13:12
@movermeyer movermeyer marked this pull request as ready for review January 8, 2021 13:14
@Lemmingh Lemmingh added the Res: Duplicate This issue or pull request already exists. label Jun 20, 2021
@movermeyer movermeyer closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Res: Duplicate This issue or pull request already exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ATX heading incorrectly parsed as setext heading if a thematic break is immediately below
3 participants
@movermeyer @yzhang-gh @Lemmingh