Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Rewrite localization & welcome #885

Merged
merged 7 commits into from
Jan 24, 2021
Merged

🐛 Rewrite localization & welcome #885

merged 7 commits into from
Jan 24, 2021

Conversation

Lemmingh
Copy link
Collaborator

Given that

  • Our changelog is in English.
  • Translating changelog is hard, and probably makes slight significance.

I decide also not to localize the welcome message.
It is now stored in the welcome.txt file.

@Lemmingh Lemmingh added Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Area: UI Related to UI controls (context menu item, notification, picker, view, etc.). labels Jan 20, 2021
@Lemmingh Lemmingh added this to the Next milestone Jan 20, 2021
@Lemmingh Lemmingh requested a review from yzhang-gh January 20, 2021 17:26
@Lemmingh Lemmingh self-assigned this Jan 20, 2021
@yzhang-gh
Copy link
Owner

Thanks a lot.

I don't have much time today but will have a closer look tonight.

not to localize the welcome message.

However, it would still be helpful to localize (just) the welcome message (falls back to English). It is okay to only provide an English changelog as we will put some GIFs there.

@Lemmingh
Copy link
Collaborator Author

falls back to English

Emmm ... OK.
Much more work to do.

BTW, I regard the "welcome message" here as distribution-exclusive component, similar to "Microsoft specific customizations" in VS Code, so, prefer not to check it into the repo.

@Lemmingh Lemmingh marked this pull request as draft January 21, 2021 04:37
@Lemmingh Lemmingh changed the title 🐛 Rewrite welcome 🐛 Rewrite localization & welcome Jan 23, 2021
@Lemmingh Lemmingh requested a review from yzhang-gh January 23, 2021 19:32
yzhang-gh
yzhang-gh reviewed Jan 24, 2021
View reviewed changes
Copy link
Owner

@yzhang-gh yzhang-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

package.nls.ja.json Outdated Show resolved Hide resolved
package.nls.zh-cn.json Outdated Show resolved Hide resolved
src/nls/index.ts Show resolved Hide resolved
src/nls/index.ts Show resolved Hide resolved
src/print.ts Outdated Show resolved Hide resolved
@Lemmingh
Copy link
Collaborator Author

BTW, have you figured out why tests randomly go timeout?

IIRC, it dates back to the time when the CI was hosted by AppVeyor.

@yzhang-gh
Copy link
Owner

The timeout issue has been there since the very beginning. I increased the time limit and thereafter it happens less often.

One solution may be #261, but it always has a low priority.

@Lemmingh Lemmingh requested a review from yzhang-gh January 24, 2021 08:08
@Lemmingh Lemmingh marked this pull request as ready for review January 24, 2021 08:17
@Lemmingh Lemmingh merged commit 08c6f57 into master Jan 24, 2021
@Lemmingh Lemmingh deleted the dev/rewrite-welcome branch January 24, 2021 08:18
Lemmingh referenced this pull request Jan 26, 2021
@Lemmingh
👷 Narrow "Test" on-pash condition
eb68857
@yzhang-gh yzhang-gh mentioned this pull request Jun 20, 2021
Open
12 tasks
@Lemmingh Lemmingh mentioned this pull request Oct 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhang-gh yzhang-gh yzhang-gh approved these changes

Assignees

@Lemmingh Lemmingh

Labels
Area: Meta Pertaining to build system, test system, infrastructure, code health, and the project itself. Area: UI Related to UI controls (context menu item, notification, picker, view, etc.).
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Lemmingh @yzhang-gh