🐛 Fix TOC visible text and GitHub slug generation #890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<div>
tags are a quirk ofvscode.markdown-language-features
, which uses them for source mapping. But we don't need.MarkdownEngine
class.IDisposable
, then we can create and register our own disposables in future.getDocumentToken()
to Markdown engines.Verification
Note:
Our heading recognition in TOC does not support multiline heading, so, you need to "Print to HTML" to inspect the last heading.
Be careful about those trailing spaces.