Player fixes

[gechoto]

Should fix #1748 #1781 #1775 #1770 #1758 #1764 #1760 #1757 #1787 #1788 #1790

This supersedes #1774 with additional improvements.

Compared to the previous PR this adds:

• fixes for metadata (normalization works again)
• support for premium formats (better audio quality for logged in users with a premium account)
• a better client fallback system and streaming url status checks so playback is more likely to work
• a fix to prevent using expired urls from songUrlCache

Current test build:
https://github.com/z-huang/InnerTune/actions/runs/13220889696/artifacts/2559580736

[gitguardian]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

---

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

[gechoto]

@z-huang can you have a look?
Many users are waiting for the next release because the latest one is broken.
Would be happy to get this done and get the app back up working again.

There is one last thing I'm not sure about. The http clients in NewPipeDownloaderImpl and YTPlayerUtils do not use the proxy yet. But I wonder if it is even worth keeping the proxy since YT usually blocks most datacenter IPs now.

What do you think? Should the proxy be removed?
If it will be kept how should it be used in NewPipeDownloaderImpl and YTPlayerUtils?

[PSJahn]

The crashing after logging in seems to be fixed in the latest commit build! (However, the youtube music webpage is opened after logging in successfully, it would maybe be better if it exited out of the login prompt automatically, after logging in successfully)
The second issue which I was facing, with the app closing itself if not connected to the internet also seems to be fixed for me!
Hope this gets merged soon!

EDIT: Playing songs, as well as downloading, also works of course!

[MLGHerobrine]

Works great! Only issue is increased startup time and decreased UI performance on a lower end device like mine (Cat S22 Flip).

It takes about 10-15 seconds for my phone to start it up, and then the UI renders slowly (5-10 FPS when scrolling)

[thornySoap]

It takes about 10-15 seconds for my phone to start it up, and then the UI renders slowly (5-10 FPS when scrolling)

@MLGHerobrine if you used the link to download the debug version, that is normal. I haven't tested but I assume that when building the release APK, performance should be as usual.

[gechoto]

Proxy support is now also added. Turns out it wasn't hard because the proxy is only applied on app start. This means if you change the proxy settings you will have to fully close and restart the app. That was already the case before and just made adding the proxy to the new http clients easier.

[Figim]

This video won't play or download when you sign in. I have selected "high" for audio quality and it shows mp4 in the details:

https://music.youtube.com/watch?v=wxHRqPtWHOU

[gechoto]

This video won't play or download when you sign in.

@Figim Please follow these steps:

1.) Clear app data (full reset without restoring a backup)
2.) Try to play the song again (without login at this point) - LEAVE A COMMENT HERE IF IT WORKS
3.) Clear app data again (full reset without restoring a backup) - YES A SECOND TIME
4.) Login in within InnerTune
5.) Try to play the songs again - LEAVE A COMMENT HERE IF IT WORKS

I have selected "high" for audio quality and it shows mp4 in the details

This PR does not change anything about the code which chooses the format.

"high" in InnerTune just means the format with the highest bitrate (for you).
It has a slight preference for opus but only to some extent so you can still get other formats in some cases.

This could be improved in the future but for now you get the same formats as with older InnerTune versions.

[Figim]

This video won't play or download when you sign in.

@Figim Please follow these steps:

1.) Clear app data (full reset without restoring a backup) 2.) Try to play the song again (without login at this point) - LEAVE A COMMENT HERE IF IT WORKS 3.) Clear app data again (full reset without restoring a backup) - YES A SECOND TIME 4.) Login in within InnerTune 5.) Try to play the songs again - LEAVE A COMMENT HERE IF IT WORKS

I have selected "high" for audio quality and it shows mp4 in the details

This PR does not change anything about the code which chooses the format.

"high" in InnerTune just means the format with the highest bitrate (for you). It has a slight preference for opus but only to some extent so you can still get other formats in some cases.

This could be improved in the future but for now you get the same formats as with older InnerTune versions.

2. Playing this video
5. This video not playing

[th3y]

While TVHTML5 works, there are some urls that returns 403 (Most of them are music videos or from video section)

• Does it return 403 consistently on the same videos or do they work if you close the app and try again a few minutes later?
• Does it fall to the IOS client for those videos and does this allow playback?

I can give you some ids to test (I think i should not share yt links)
zqoj_3r9oqg
6cNFimD69ns
O-B-BBwfAWU
IQQ4ZFtDShE
vQqGz1yqYrE

Its not about the owner channel, i think it could be related from the 'embed' or something behind it, they are managed in a different way

[th3y]

i tried different browser

If it doesn't even work with the official client in a browser your IP or account might be blocked.

i can't never be sure of using IOS since its having problems sometimes (30 seg playback and error)

How often does this happen? Can you test if it also happens with NewPipe if you apply this PR TeamNewPipe/NewPipeExtractor#1262 ?

Im sorry, typo error, it works with official client.

IOS gives 30 seg error or LOGIN_REQUIRED (Confirm you are not a bot) sometimes. Or it plays at 30 seg and then error.
Lets says its not 100% stable.

About the PR, i can't test it right now

[th3y]

i tried different browser

If it doesn't even work with the official client in a browser your IP or account might be blocked.

i can't never be sure of using IOS since its having problems sometimes (30 seg playback and error)

How often does this happen? Can you test if it also happens with NewPipe if you apply this PR TeamNewPipe/NewPipeExtractor#1262 ?

Today i migrated the code to kotlin, and with mobile data i didn't get any playback error with IOS (Of course age restricted videos are not working)
I guess the code its working because the visitor data includes a (Time) - RandomTime (Max 5 days back), and the Country Code.
i would like to figure out what happened if i use my real visitordata. But i can't test it today

Edit:
Playback working without error with my visitorData

[gechoto]

Edit:
Playback working without error with my visitorData

@th3y Was this in NewPipe or InnerTune? Is there a difference between the two for you?

Edit:
In case it works in NewPipe for you but NOT InnerTune please test if this commit changes anything:
gechoto@b26487d

[th3y]

Edit:
Playback working without error with my visitorData

@th3y Was this in NewPipe or InnerTune? Is there a difference between the two for you?

Edit: In case it works in NewPipe for you but NOT InnerTune please test if this commit changes anything: gechoto@b26487d

Im using NewPipe for login only. (The last comment was about IOS client)
I'll test your recent changes and let you know after about a day of testin

[th3y]

Edit:
Playback working without error with my visitorData

@th3y Was this in NewPipe or InnerTune? Is there a difference between the two for you?

Edit: In case it works in NewPipe for you but NOT InnerTune please test if this commit changes anything: gechoto@b26487d

Playback OK without problem or skips (Using your commit too)

[Figim]

NewPipe is preparing a new PR with a new potoken version of Extractor that will be released soon to fix bot and http 403 errors.

PR for extractor: TeamNewPipe/NewPipeExtractor#1272

PR For application: You should update the extractor and prepare such a pr

TeamNewPipe/NewPipe#11955

[Figim]

New PR to fix iOS player error, bot and http 403: TeamNewPipe/NewPipeExtractor#1272

[gechoto]

Hi @z-huang is this project still active?
There are already new challenges put in place (I currently work on po token support) but I don't know if I want to spend time to keep this PR maintained forever if the project is not active anymore.
What are your plans about the future of InnerTune?

[Figim]

@gechoto hello There is such a popular app, but no one has added PoToken support.
https://github.com/fast4x/RiMusic/pulls?q=is%3Apr+is%3Aclos

[th3y]

Hi @z-huang is this project still active? There are already new challenges put in place (I currently work on po token support) but I don't know if I want to spend time to keep this PR maintained forever if the project is not active anymore. What are your plans about the future of InnerTune?

May i ask
What does PoToken do now?
I mean, as far i can see, its focused for WEB_REMIX (Logged In), i just tested OuterTune and there's no changes with guest client. I have the error (LOGIN REQUIRED) with Mobile Data.
This is likely the same scenary, so i was wondering if PoToken its just a improved way to playback for WEB_REMIX + Login User, but does this fix error 403 after extracting some urls?

[Figim]

Hi @z-huang is this project still active? There are already new challenges put in place (I currently work on po token support) but I don't know if I want to spend time to keep this PR maintained forever if the project is not active anymore. What are your plans about the future of InnerTune?

May i ask What does PoToken do now? I mean, as far i can see, its focused for WEB_REMIX (Logged In), i just tested OuterTune and there's no changes with guest client. I have the error (LOGIN REQUIRED) with Mobile Data. This is likely the same scenary, so i was wondering if PoToken its just a improved way to playback for WEB_REMIX + Login User, but does this fix error 403 after extracting some urls?

Some clients require PoToken, some require logins. The app automatically chooses the best one. You log in and continue. Does OuterTune use NewPipe extractor? Newpipe transmits iOS visitor data for bot errors. Each client uses different visitordata and potoken. PoToken fixes 403 errors

[gechoto]

What does PoToken do now?

It makes playback possible with the WEB_REMIX client in more/(most?) cases. Without po tokens this client only works for premium users.

i just tested OuterTune and there's no changes with guest client. I have the error (LOGIN REQUIRED) with Mobile Data.

Does playback work for you on the official website on the same device and mobile data connection in a private browser window?

Does OuterTune use NewPipe extractor?

Only small parts of it. Just like InnerTune with this PR.

Newpipe transmits iOS visitor data for bot errors.

Both InnerTune and OuterTune get visitor data in a different way than NewPipe.

Each client uses different visitordata and potoken.

Currently the same visitor data is used across all clients and po tokens are only supported for the WEB_REMIX client.

[Figim]

What does PoToken do now?

It makes playback possible with the WEB_REMIX client in more/(most?) cases. Without po tokens this client only works for premium users.

i just tested OuterTune and there's no changes with guest client. I have the error (LOGIN REQUIRED) with Mobile Data.

Does playback work for you on the official website on the same device and connection in a private browser window?

Does OuterTune use NewPipe extractor?

Only small parts of it. Just like InnerTune with this PR.

Newpipe transmits iOS visitor data for bot errors.

Both InnerTune and OuterTune get visitor data in a different way than NewPipe.

Each client uses different visitordata and potoken.

Currently the same visitor data is used across all clients and po tokens are only supported for the WEB_REMIX client.

So why don't you use iOS? It's pretty stable now.

[gechoto]

So why don't you use iOS? It's pretty stable now.

It is still in use as a fallback client but it does not work reliably for all users.

[th3y]

What does PoToken do now?

It makes playback possible with the WEB_REMIX client in more/(most?) cases. Without po tokens this client only works for premium users.

i just tested OuterTune and there's no changes with guest client. I have the error (LOGIN REQUIRED) with Mobile Data.

Does playback work for you on the official website on the same device and connection in a private browser window?

Does OuterTune use NewPipe extractor?

Only small parts of it. Just like InnerTune with this PR.

Newpipe transmits iOS visitor data for bot errors.

Both InnerTune and OuterTune get visitor data in a different way than NewPipe.

Each client uses different visitordata and potoken.

Currently the same visitor data is used across all clients and po tokens are only supported for the WEB_REMIX client.

So why don't you use iOS? It's pretty stable now.

IOS is not stable. Me and some users have problems with Mobile Data. Its still showing 'Log in to continue' most of the times in non age restricted videos. Under WIFI it works pretty stable. it needs log-in for age restricted videos tho.

[th3y]

Btw @gechoto could you keep updating and add PoToken in this PR?

[gechoto]

Btw @gechoto could you keep updating and add PoToken in this PR?

I don't know yet since this is possibly going nowhere.

For now I focus on OuterTune first because it is an active project where more people can enjoy the fixes.

[th3y]

Btw @gechoto could you keep updating and add PoToken in this PR?

I don't know yet since this is possibly going nowhere.

For now I focus on OuterTune first because it is an active project where more people can enjoy the fixes.

Thanks in advance, im trying to get it work in a private build from other project, but without success.