Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty http path and method in permission allows any route open; #5741

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexoleynik0
Copy link

@alexoleynik0 alexoleynik0 commented Mar 22, 2023

Original issue -- #5739
I can't tell why this was designed like that, and the chances that after 6+ years it's safe to change it are not very high. Still, there's really no indication anywhere on the "Permission create" page that any Permission without http_path and http_method filled will give full access to any route and method.
It may be better to restrict empty values there (eg make http_path required) to prevent this.

@alexoleynik0 alexoleynik0 linked an issue Mar 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission with empty HTTP path matches all routes
1 participant