fix: empty http path and method in permission allows any route open; #5741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue -- #5739
I can't tell why this was designed like that, and the chances that after 6+ years it's safe to change it are not very high. Still, there's really no indication anywhere on the "Permission create" page that any Permission without
http_path
andhttp_method
filled will give full access to any route and method.It may be better to restrict empty values there (eg make
http_path
required) to prevent this.