Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some titles may return 'unknown' media_type #545

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Some titles may return 'unknown' media_type #545

merged 1 commit into from
Jan 20, 2021

Conversation

zn3x
Copy link
Contributor

@zn3x zn3x commented Jan 20, 2021

Related to #532

@z411 z411 merged commit 981bdac into z411:master Jan 20, 2021
@z411
Copy link
Owner

z411 commented Jan 20, 2021

Thank you!

@z411 z411 mentioned this pull request Jan 20, 2021
Closed
@FichteFoll
Copy link
Collaborator

FichteFoll commented Jan 20, 2021 •
edited
Loading

Shouldn't 'unknown' map to … the unknown type?
(conflicts with #491, which would have done just that)

@zn3x zn3x deleted the patch-1 branch January 20, 2021 17:48
@zn3x
Copy link
Contributor Author

zn3x commented Jan 20, 2021

Yeah, if you say so.
I used other, because media_type is defined.
The only example I did found where utils.TYPE_UNKNOWN is where None is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zn3x @z411 @FichteFoll