Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial paginated search implementation #688

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahmubashshir
Copy link
Contributor

@ahmubashshir ahmubashshir commented Apr 21, 2023

  • engine: Add pagination support skeleton
  • kitsu: Implement paginated search
  • Gtk: Implement paginated search

Pagination in search dialog

Implementation

  1. API libraries must implement paginated .search(), if pagination is unsupported, page count will be 1
  2. If engine.search(...) is called with page=N ti returns paginated result, otherwise it returns an array of first n results (old behavior)
  3. paginated results are returned like this [ results[], len(results[]), pagenum, pages ]

Related #687

Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant