Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Areas support. Updated example application to include areas sup… #66

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Added Areas support. Updated example application to include areas sup… #66

merged 1 commit into from
Jul 30, 2020

Conversation

sethsteenken
Copy link
Contributor

…port and areas with custom routing.

Included a NodeKey class to handle the logic around building a key from the route dictionary. Updated the extension methods on type responsible for generating the node keys to include a check on the AreaAttribute. Tested logic against example app which now includes Area support.

@sethsteenken
Copy link
Contributor Author

Related issues - #33 #37

@zHaytam
Copy link
Owner

zHaytam commented Jul 29, 2020

Hello,
Thank you very much for the PR!
I will be trying it tomorrow to see if it's ready to be merged, sorry for the delay.

@sethsteenken
Copy link
Contributor Author

Sure thing! No worries at all on the delay. Hit me up if you have any questions or concerns about the PR.

@zHaytam zHaytam merged commit 745bf65 into zHaytam:master Jul 30, 2020
@zHaytam
Copy link
Owner

zHaytam commented Jul 30, 2020

Looks good to me, merged!
Thanks again, 3.5.0 will be in NuGet shortly!

@sethsteenken
Copy link
Contributor Author

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants