Fix this.lexer undefined, fixes #246 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that 9e0cc65 introduced a bug in the generated code, such that `this.lexer` is undefined, and so it throws a runtime error. This fixes the bug, and also adds a test to reproduce the error. The test fails before the fix, but succeeds after. I ran the tests and confirmed 100% success and no errors.
| 'expressions\n : e EOF\n {return $1;}\n ;\n\n' + | ||
| 'e\n : phrase+ \'joy\'? -> $1 + \' \' + yytext \n ;\n\n' + | ||
| 'phrase\n : \'happy\' \'happy\' \'joy\' \'joy\' ' + | ||
| ' -> [$1, $2, $3, $4].join(\' \'); \n ;'; |
There was a problem hiding this comment.
Yes, I actually wrote this just for the test. Fun exercise. :)
|
+1, can confirm that this fixes #246. |
|
Please merge :-), I'm encountering the same problem |
|
+1 i confirm it fixes the issue too |
|
For anyone who's stuck waiting for a merge, you can add this to your |
zaach
added a commit
that referenced
this pull request
Aug 18, 2015
Fix this.lexer undefined, fixes #246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that 9e0cc65 introduced a bug in the generated
code, such that
this.lexeris undefined, and so itthrows a runtime error.
This fixes the bug, and also adds a test to reproduce the
error. The test fails before the fix, but succeeds after.
I ran the tests and confirmed 100% success and no errors.