Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colourized word list suggestion #4

Closed
thiagonogueira opened this issue Mar 8, 2017 · 5 comments
Closed

colourized word list suggestion #4

thiagonogueira opened this issue Mar 8, 2017 · 5 comments

Comments

@thiagonogueira
Copy link

First of all congrats and thank you for the great work!

Here are some words don't appear colourized on my sql files I believe it should be:

DROP
FUNCTION
PROCEDURE
NUMBER
CURSOR
COMMIT
EXECUTE
IMMEDIATE
RANK
OVER
PARTITION
BY
COUNT
SUM
EXISTS
PIVOT
UNPIVOT
NOTFOUND

I've taken a look at the source code but since I'm neither a regex nor a sql expert I could easily mess everything up if trying to implement by myself.

Kind Regards,
Thiago

@zabel-xyz
Copy link
Owner

Thank you for the list (some words are already colourized)
image

I'll complete the keyword list to improve syntax highlight (with your list and another)....

@thiagonogueira
Copy link
Author

thiagonogueira commented Mar 14, 2017

Not sure why, but some words you've posted are not working here...

image

image

image

image

@zabel-xyz
Copy link
Owner

procedure and function are special keywords.
Currently they are colored only when they appear at the beginning of the line (not after drop or create ...) and with a name after.

For other keywords:
Which theme do you use? Do they work with another color theme (e.g. Monokai)?
image

@thiagonogueira
Copy link
Author

thiagonogueira commented Mar 16, 2017

I use Humane theme. I've tested colouring schema with Monokai and it worked.

@zabel-xyz
Copy link
Owner

fix in version 0.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants