Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorization of the parameters (Update plsql.tmLanguage) #23

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Danieleeee
Copy link

@Danieleeee Danieleeee commented Jun 17, 2017

Reference to Issue 22

@zabel-xyz
Copy link
Owner

Sorry, but I can't push your suggestion.
Cause several problem (see my printscreen)
image
Other consequence: keyword like using is in a wrong color...

Currently the rules are:
po_, pi_, pio_ are detected as parameter variable
l_ are detected as local variable

Perhaps its not the rules you use. I don't know if we can improve this in a standard way.
You can also customize the colorization syntax for your usage see here

@zabel-xyz zabel-xyz changed the title Update plsql.tmLanguage Colorization of the parameters (Update plsql.tmLanguage) Jun 18, 2017
@Danieleeee
Copy link
Author

The same argument applies to your variables:
1
The point is that if we want to set rules, we can assume that the input parameters can start with the letter p***_.

Forcing the rule to only pi, po and pio parameters seems a little restrictive.
Above all considering the fact that it is not a fixed rule of plsql language, but a convention.
Also in the PR that I provided you there is the rule to highlight all the parameters followed by IN, OUT and IN OUT, which does not create any problems and is very similar to how the typescript highlights its parameters:
2

@Danieleeee
Copy link
Author

I have update the PR so you don't have problems with in out:
1

@Danieleeee
Copy link
Author

You can also customize the colorization syntax for your usage see here

If I change tmLanguage file it is overwritten when I update the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants