fixes #80, #81 #83
Open
fixes #80, #81 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I was just looking into the same fix. Regards, |
- needed this to be able to run npm install without errors - vscode is deprecated - 1.137 seems to be the last version - `npm install` was now successful - `vsce package` was also successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
here the fixes for the two issues opened by me. Feel free to revoke the pull request and let me know what is missing or wrong.
Comment on the syntax highlighting: I learned a lot. Instead of adding one new entry like you mentioned I had to add multiple ones - otherwise it would not work because of mixed start and end characters (regex "or"). Hope this will not slow down the parser.
Comment on the symbol recognition: Beneath the four regexes for the brackets I tried to add one generic one with a back reference like so:
/q'(.)[\s\S]*?\1'/gi. This is working when I try it on regexr.com/4g99i (I saved it for you) but unfortunately not when I use it in the regex parser for the symbol recognition. I have no idea why this is not working there. So I had also to use here the same approach as for the syntax highlighting and provide for each needed character an own regex expression. Currently I support these characters:() [] {} <> | ! # ` ^.I added also a file
main/test/sql/ogobrecht_alternativeQuoting.sql. Please let me know, if I should integrate this test file in the existing package filemain/test/sql/xyz_myPackage2.pkb.Best regards
Ottmar