Backend CI cleanups and improvements #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dapolach
commented
Sep 14, 2024
dapolach
commented
- no GITHUB reference from gradle file
- docker image build just once
otahirs
requested changes
Sep 14, 2024
| @@ -34,13 +35,11 @@ jobs: | |||
|
|
|||
| - name: Build and Publish Docker Image | |||
| working-directory: backend | |||
| env: | |||
There was a problem hiding this comment.
Tady bych nastavil DOCKER_REGISTRY_USERNAME
a pod
There was a problem hiding this comment.
Proc? Neni pro to zadny duvod.
There was a problem hiding this comment.
you are right, i missed that that the gradle task is now used for build only
otahirs
reviewed
Sep 14, 2024
|
sorry for my confusion, checking PR from mobile phone might not be one of the best of my ideas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.