Allows for query params in SVG import statements #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatsby's out-of-the-box config matches the following import statements:
import someIcon from './some-icon.svg';
import someOtherIcon from './some-other-icon.svg?key=value';
That is, you can import `file.svg?query-params-here` and it'll be matched, even though
that module doesn't strictly end in `.svg`.
To keep that same functionality, we just need to adjust our `test`
regular expression to more closely match what Gatsby previously had set.
|
Can you elaborate on what including query parameters here does given that this plugin doesn't do anything with them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatsby's out-of-the-box config matches the following import statements:
That is, you can import
file.svg?query-params-hereand it'll be matched, even though that module doesn't strictly end in.svg.To keep that same functionality, we just need to adjust our
testregular expression to more closely match what Gatsby previously had set.This is useful if you are using things like svg-transform-loader.